Yingchun Lai

Results 153 comments of Yingchun Lai

共用rpc我觉得倒没有问题。问题点应该在count数值应该放在哪里,序列化在 `struct get_scanner_request` 里面不是很合适,在 `scan_request` 里面加一个标记表示是否只取count,并在 `scan_response` 把count结果带出来或许更合适。 新增的字段都是 optional 的,当server端是老版本,即不支持这个新增字段的判断时,会使用老接口逻辑把kv原始数据带出去,新的client可以以此判断server端是否支持,如果不支持,业务逻辑层可以返回失败。 更干净的做法当然还是新增一个独立的rpc,但是get_scanner还是可以复用的。

Has been implemented by https://github.com/apache/incubator-pegasus/pull/1091, so I close it. Thanks @ZhongChaoqiang

resolved by https://github.com/apache/incubator-pegasus/pull/1030

> Hi, I noticed that license problem is one of the issues highlight by apache (https://whimsy.apache.org/board/minutes/Pegasus.html) to prevent upgrade out of incubation. Is this expected to be resolved relatively soon?...

Could you give some performance comparation with the old version ?

It is also tracked in Ranger community https://issues.apache.org/jira/browse/RANGER-3831

The current ACL is described in https://github.com/apache/incubator-pegasus/issues/170 and [Pegasus 安全认证](https://mp.weixin.qq.com/s?__biz=MzkzNzAzNDgyNg==&mid=2247483801&idx=1&sn=0516fcdfb3667b85d03eb5a40293e6de&chksm=c294d4bcf5e35daa67a4eb3317749c7a643e09a54c5c886be407a1105d96c6607c416cb4310c&token=1577740624&lang=en_US#rd) It can be summarized as following: operation \ user | super user | table owner | other users -- |...

1. More restrict for common query type requests. a. As table above, users should be granted 'metadata' before query cluster info. 2. MetaServer have to support table level ACL a....

1. 需更严格的普通查看类请求: a. 如上表格,“Global级别权限”的“metadata”权限也需要ACL 2. meta server上增加表级的ACL: a. 如获取表的路由信息(RPC_CM_QUERY_PARTITION_CONFIG_BY_INDEX),也需做ACL 3. 为支持database(前缀)粒度的控制: **a. meta server上的:** i. 针对如上列表中的“Database级别权限”的在metaserver上处理的请求 ii. 需增加unordered_map的结构 iii. 在各个请求响应函数中,解析到请求的”表名“之后加以判断 **replica server上的:** i. 需增加与meta server上相似的数据结构(unordered_map) ii. 因为”表前缀”并不属于任何表,所以除了表级的envs外,还需增加server级的envs,用于鉴权 iii. 因为在replica server上并不维护“表名”,而只有“表id”,所以还需增加表id与表名的映射关系...