Andrew Clayton
Andrew Clayton
Couple of quick questions. What _variables_ are we talking about here? Is the afore mentioned discussion available anywhere?
> │ What variables are we talking about here? > Variable-related APIs, correspond to `nxt_tstr_{api}`. njs variables? > │ Is the afore mentioned discussion available anywhere? > I'm afraid no...
> It means Unit variables, for example, $host . This has nothing to do > with njs here. Perhaps that should be made clear in the commit message then...
I wonder if ``` 4d515d54 Var: Removed unused functions and structure fields ``` and ``` 2cb6b1bf Var: Removed unused functions ``` should be combined?
HI @hongzhidao The only thing you might want to do to be consistent with recent commits is to lowercase the `Var`'s and `HTTP`s in the commit subjects...
Ah, while this is awaiting merging (or not), we should change the commit subjects to be in ["imperative mood"](https://cbea.ms/git-commit/#imperative), e.g `var: Restrict nxt_tstr_query() to only support synchronous operation` => no...
No need to make a new PR. You can un-draft this one! See the `Ready for review` button? (just below the checks...) I've had a look at the latest patch,...
> Hi @ac000, Would you mind I merge the prepared variable related patches now? I think they are ready. Which patches exactly? These still have at least the typo in...
Could you push just what you intend to merge for clarity?
Ah, right I see now, OK then...