Andrew Clayton
Andrew Clayton
Do you have a simple reproducer app and config?
That app starts reliably on Linux with OpenJDK 21. It does fail to start sometimes on macOS with OpenJDK 23.
@gdufrene Been a while! and if you've moved onto other things no worries and even though Unit has effectively transitioned into [maintenance](https://github.com/nginx/unit/blob/master/SUPPORT.md) mode, I had been meaning to test that...
Hi @thresheek could you double check what you pushed up as the commit message doesn't seem to have changed (though the subject has)...
> Yeah it's a good idea - however I'm pretty sure we're quite close to > the bugfix release where we don't really want to bump too many things. >...
This doesn't really fit in with Units architecture. For most languages, the language runtime runs in process and the HTTP request is passed from the router process to the application...
> Variables don't contain spaces so why would we put (escaped) quotes ( \" ) > around it? I also think the $ prefix would make it clearer. The `"`'s...
I think this patch is fine for what it's doing. The other suggestions would likely be a larger more intrusive patch.
@kbzowski These messages do not necessarily indicate an actual issue. Are you seeing some actual misbehaviour in your application?
FWIW we hit the same issue in Unit. For now we've disabled this warning until hopefully this [patch](https://gcc.gnu.org/pipermail/gcc-patches/2024-December/671714.html) (or similar) makes it into GCC then we can re-enable the warning...