Andrew Clayton
Andrew Clayton
> FWIW `--with-cc-opt="-Wno-error=unterminated-string-initialization"` works for clang as well. Hmm, which version of clang is that? AFAICT clang has no such option... However seeing as the above mentioned patch has now...
> @ac000 > > > can be handled properly > > do you have a link for that? The linked commit will allow `__attribute__(("nonstring"))` to silence this warning, e.g. you...
> It says "UNIT" in a few places This should be part of
Cc: @javorszky
> Author field should be some collective ("The NGINX Unit Team" instead of Elijah) ```unit-openapi/Cargo.toml:4:authors = ["[email protected]"]``` Who gets that email?
Elijah's name appears in a few places ``` tools/unitctl/man/unitctl.1:20:Elijah Zupancic \fB\fR tools/unitctl/unit-client-rs/Cargo.toml:4:authors = ["Elijah Zupancic"] tools/unitctl/unitctl/Cargo.toml:5:authors = ["Elijah Zupancic"] ``` I'm a little uneasy just removing his authorship. At the...
s-o-b is short for `Signed-off-by`
> As for `Cargo.toml`, isn't the custom to add all of the major contributors? Yes, happy to do it that way.
OK, so I did kind of forget about this but then it is also not clear what to do about the `[email protected]` email address which appears in a few places...
Hi @rustedsword Thanks for your report and initial investigations, thanks for getting the backtrace from the coredump. I'll see if i can repreducing this, thanks for the script! (though I...