Andrew Clayton
Andrew Clayton
On Wed, 15 May 2024 03:36:52 -0700 Allwin Winfred J ***@***.***> wrote: > npm ERR! In file included from ../unit.h:9, > npm ERR! from ../unit.cpp:6: > npm ERR! ../nxt_napi.h:17:10: fatal...
> 2. I expect the purll request to be squash-merged. See no reason to keep this history of commits _If_ you keep the ci.yml change, then that should at least...
Yes, I'll take a look.
> > Can we get this PR converted to a non-draft PR? > > Does non-draft PR mean it's ready to review? And it will run with GH actions for...
> We need to land something ASAP, and should act as though the deadline Actually, I don't think we do, not in the main Unit repository anyway... > to have...
Hi @hongzhidao good job! I see this is still marked as a draft, but I'll do a quick once over your latest patch while I notice some minor things... One...
> > One small other nit, perhaps you could reword the subject to something like > > Support chunked request bodies > > Good suggestion, let me know if `body`...
Ignore the Fedora Rawhide failures, Rawhide seems broken at the moment...
Hi @hongzhidao You can add my ``` Reviewed-by: Andrew Clayton ``` to ``` http: Move chunked buffer pos pointer while parsing ```
Why remove the link to the chunked issue?\\ **EDIT:** Hmm, I guess because this won't be enabled by default...