Andrew Clayton

Results 552 comments of Andrew Clayton

> > Hi @hongzhidao > > You can add my > > ``` > > Reviewed-by: Andrew Clayton > > ``` > > > > > > > > >...

OK @hongzhidao good stuff! I think you can add my ``` Reviewed-by: Andrew Clayton ``` to that last commit now...

Can we clear this up once and for all!? https://github.com/nginx/homebrew-unit/issues/39#issuecomment-2113815977

Hmm, it does seem that way... I thought it worked the other way around, i.e a release would be triggered on a tag being pushed. > Is there something I'm...

> So the release step happens whenever we push a tag matching '[0-9]+.[0-9]+.[0-9]+', or when we manually invoke the workflow. Yeah, that's what I thought... so if we want to...

Good point! bit of a chicken & the egg problem...

On Thu, 16 May 2024 16:18:14 -0700 avahahn ***@***.***> wrote: > > From some initial searching, it looks like a [tag is required](https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release) for published releases and prereleases, but it...

Can that be created as a _lightweight_ tag so it doesn't interfere with the likes of git-describe(1)?

To be honest I'm too uneasy with this whole concept that it wouldn't be appropriate for _me_ to approve this...

What's the .a mean? and do we need unitctl in there twice?