Andrew Clayton

I don't think we need these anymore... seeing as we're no longer using RB. ``` (howto/reviewboard: line 51) broken https://www.reviewboard.org/docs/manual/dev/admin/installation/creating-sites/#changing-permissions - Anchor 'changing-permissions' not found (howto/reviewboard: line 1) broken https://www.reviewboard.org/docs/manual/dev/admin/installation/linux/#before-you-begin...

Hi @drmad Could you make a minor tweak to the commit message and just stick the URL on the next line and enclose it in ``'s, that way we keep...

Hi, AFAICT Unit really _only_ supports OpenSSL. For example the other TLS implementations do something like ```c const nxt_ssltls_lib_t nxt_gnutls_lib = { nxt_gnutls_server_init, NULL, }; ``` `nxt_ssltls_lib_t` is not defined...

It looks like the idea was to support TLS libraries other than OpenSSL, see; _src/nxt_gnutls.c_, _src/nxt_cyassl.c_ & _src/nxt_polarssl.c_, however it seems this work was never fully realised. I've never really...

> What about adding an auto target (like the rest of Unit's makefiles) for unitctl since those work fine on macOS? The `auto/` stuff is driven via `./configure` and is...

@avahahn Feel free to give me your `Reviewed-by:` like [here](https://github.com/nginx/unit/pull/1166#issuecomment-1981582764) (only seeing as there's a single commit you don't need to mention which commit ;))

Thanks, holding off merging as I'm anticipating on needing to add an entry for @oxpa soon.

Added Ava's `Reviewed-by:` ``` $ git range-diff 180060a4...2820e795 1: 180060a4 ! 1: 2820e795 .mailmap: Add an entry for Ava's GitHub address @@ Commit message See gitmailmap(5) + Reviewed-by: Ava Hahn...

Rebased with master ``` $ git range-diff 2820e795...44709bea -: -------- > 1: 237a26aa wasm-wc: Bump the rustls crate from 0.21.10 to 0.21.11 -: -------- > 2: 3fbca6ca Fix some trailing...

> not really covered: the buildbot workflow _should_ mostly ensure that we can build packages on a target. So I went with a subset of OSs that have unit packages....