Andrew Brown

Results 326 comments of Andrew Brown

It's done for wasi-common but I haven't yet propagated it to wasi-nn and wasi-crypto. Should I create separate issues for those and close this one?

@Milek7, you may be interested in https://github.com/WebAssembly/component-model/pull/291. Let's talk more tomorrow on Zulip; maybe you want to help out with implementing some of those bits?

Here is the raw output of the benchmarking I did on my current system. It is hard to interpret the results (is it too noisy? not enough runs?) but here...

@jianjunz:now that #7846 is merged you should be able to rebase on that and get `cargo vet` to pass.

@doinkythederp, thanks for the codespace reproducer. Here's what I get when I follow your instructions: ![image](https://github.com/bytecodealliance/wasmtime/assets/541880/dc23a44a-0343-4549-9d18-5d8e2da8c11e) It looks like, as @cfallin suggested, those values are being optimized away. But when...

Ok, here's how I verified that WebAssembly/wasi-libc#491 actually fixes this issue: - built [wasi-libc](https://github.com/WebAssembly/wasi-libc) with threads support: `make THREAD_MODEL=posix` - in each of the `sysroot/*` directories, I had to "rename"...

I was looking at old issues and ran across this one (sorry for such a late reply!): I completely agree with this idea. I am tempted to say "go for...

Looks good to me! Thanks for the changes. Can you amend your commit and add the following somewhere in the doc message so we can trigger the doc build? ```...