Andrew Brown

Results 326 comments of Andrew Brown

I think this is related to https://github.com/llvm/llvm-project/issues/55781.

@sunfishcode, this seems like a nice feature to have, do you want to rebase it?

@turbolent, you mean build it manually or distribute it as a part of the release artifacts?

@devigned, I'll take a closer look next week. I will say I've been been changing the ground under your feet here (sorry 😁) with https://github.com/bytecodealliance/wasmtime/pull/7679; that PR will mean we...

@devigned. I see a bunch of dependencies for the [failing vet check](https://github.com/bytecodealliance/wasmtime/actions/runs/7836371527/job/21383872144?pr=7691#step:5:15): ``` bytemuck:1.14.2 missing ["safe-to-deploy"] bytes:1.5.0 missing ["safe-to-deploy"] castaway:0.2.2 missing ["safe-to-deploy"] color_quant:1.1.0 missing ["safe-to-deploy"] compact_str:0.7.1 missing ["safe-to-deploy"] crunchy:0.2.2 missing...

> @abrown, I've trimmed down to about as slim as I think I can get the dependencies. I've removed any dependency on `half` and `ndarray` which cut the list of...

I audited the dependencies this PR would bring in and the only crate I didn't audit was `compact_str`: I do not feel comfortable putting a stamp of approval on this...

> downloaded binaries not available for target riscv64gc-unknown-linux-gnu That's fine; this just needs a few more target checks.

@jameysharp, sounds like you have some previous context for this change?