Alberto Benegiamo

Some more benchmarks here https://github.com/ava-labs/avalanchego/pull/1467

@joshua-kim validators have been moved to their own package. The PublicKey initialization changes cause some minor conflicts. Please solve them.

```mermaid stateDiagram-v2 master --> P_chain_fee_calculator P_chain_fee_calculator --> P_chain_meter_txs P_chain_meter_txs --> P_chain_update_unit_fees P_chain_update_unit_fees --> P_chain_priority_fees ```

> would it be possible to move all the property based tests to a separate dir? They used to be in a different package. What is annoying is that property...

```mermaid stateDiagram-v2 master --> X_chain_fee_calculator X_chain_fee_calculator --> X_chain_meter_txs master --> X_chain_consolidate_tx_creation X_chain_consolidate_tx_creation --> X_chain_meter_txs X_chain_meter_txs -->X_chain_update_unit_fees X_chain_update_unit_fees -->X_chain_priority_fees ```

> Thanks for putting this up! > > I wonder what the best way to document the various transaction types on the P-Chain is. It seems like this is the...

> I believe our current model for VMs is they are initialized with genesis bytes: https://docs.avax.network/build/vm/create/golang-vm-complex#virtual-machine-methods > > This feels like a step in the wrong direction. I think to...

> Also another thing we should think about is how we want these new node ids to look. Are we going to keep the `NodeID-` prefix or are we just...

abenegia@avaLabs:~/work/avalanchego$ go test -run=^$ -bench ^BenchmarkGetCanonicalValidatorSetByDepth$ github.com/ava-labs/avalanchego/vms/platformvm/warp/benchmarks -cpuprofile=cpuprofile.out goos: linux goarch: amd64 pkg: github.com/ava-labs/avalanchego/vms/platformvm/warp/benchmarks cpu: Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz BenchmarkGetCanonicalValidatorSetByDepth/0-12 20356 57927 ns/op BenchmarkGetCanonicalValidatorSetByDepth/1-12 22956 50642 ns/op BenchmarkGetCanonicalValidatorSetByDepth/2-12...

> I feel like we should probably be separating benchmarks for `GetCanonicalValidatorSet` and `GetValidatorSet` rather than expanding tests for `GetCanonicalValidatorSet` to include the actual `GetValidatorSet` implementation @StephenButtolph , I think...