avalanchego
avalanchego copied to clipboard
ava-labs
Introducing GenericNodeID
Why this should be merged
We relax the lenght requirement of NodeID type and allow avalanche go to smoothly handle NodeID of potentially different sizes and be more future proof. Coreth counterpart is https://github.com/ava-labs/coreth/pull/339
How this works
Renamed existing nodeID to ids.ShortNodeID and introduced a new ids.NodeID type with no constraints over its size.
How this was tested
CI (mainnet sync tbd)
Also another thing we should think about is how we want these new node ids to look. Are we going to keep the
NodeID-prefix or are we just going to just use a public key string?
@joshua-kim good point. For the time being I kept the prefix to ensure backward compatibility. We could update this later on if needed
This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.