Jesse Rosenberger comments

Results 294 comments of


                                            Jesse Rosenberger

Added integrity checks on operations and selection sets

Totally reasonable to re-open this, but I'll close this for now!

At least the metric `apollo_router_session_count_total` is violating Prometheus naming best-practices

Thanks for opening this. We agree. Unfortunately, this is one of our oldest metrics (perhaps one of the first!). We admit we made a mistake with its naming, but changing...

At least the metric `apollo_router_session_count_total` is violating Prometheus naming best-practices

For what it's worth, in all the dashboards I've ever seen this on, I don't actually personally get a ton of value out of this metric versus just general request-based...

tell jemalloc to use 64-KiB pages

@mergify copy dev

router v2.1.0 fails to start, error on otlp metrics service not implementated

What is the value of your `OTEL_EXPORTER_OTLP_ENDPOINT` environment variable? Is it possible that this related to https://github.com/apollographql/router/pull/6816?

router v2.1.0 fails to start, error on otlp metrics service not implementated

Could we try again on the latest version of the Router? I'm curious if this was fixed by https://github.com/apollographql/router/pull/7595.

chore(tests): Apply nextest retries rules to known-flaky tests.

Unfortunately, `/enterprise/entity-cache/invalidation-subgraph-type` just failed actually 3 times.

Propagate errors from subgraph without hiding

This sounds like it could be potentially a bug. Do you know if there were any previous versions of the Router that didn't cause this? And is it possible for...

fix(coprocessor): improve handling of invalid GraphQL responses with conditional validation

@mergifyio backport dev

fix(coprocessor): improve handling of invalid GraphQL responses with conditional validation

@mergifyio backport dev