Jesse Rosenberger
Jesse Rosenberger
Totally reasonable to re-open this, but I'll close this for now for focused review reasons.
I'm going to assume this isn't happening in its current form and clean up one more old PR.
Totally reasonable to re-open this, but I'll close this for now for focused review reasons.
One of the reasons we consciously imposed this limitation initially was to actively **prevent** folks from checking in static secrets, particularly since we think the configuration files themselves might at...
> * This is an incompatible change and could break someone. Not sure I can understand the break. How would it be incompatible under which circumstance? My understanding is it...
ok, sounds like this would be more of a breaking change than i'd thought. > It's incompatible because you are deleting the `supergraph-cm.yaml` template. That means anyone using the existing...
@carodewig Can you update the PR description on this (or just comment) with an example of what the response will look like after this change if [`include_subgraph_errors`](https://www.apollographql.com/docs/graphos/routing/observability/subgraph-error-inclusion) is **not** enabled?
@BrynCooke I think this might be ready for another review from you?
This was a defensive attempt to get out ahead of a git-bisect, but we found the actual root problem elsewhere, so I can close this.
#6312 now runs `test_updated` as a separate job, on a crontab, and connected to a Slack channel that is monitored. Thanks for the inspiration, and the paper-cut-curing.