Mohamed ABDELLANI

Results 49 comments of Mohamed ABDELLANI

For the last task, I think that it's not possible with the current validation in the product model.

@drummer83 the PR is ready then :)

@mkllnk Can you please provide more details? Am I supposed to write new tests? or just add some assertions in the existing tests?

I want to work on this, Please assign it to me. It's a good opportunity to explore the code used to generate the report : )

Hi There is one test failing among `(spec/system/admin/[a-o0-9]*)` in the pipeline. When I run the tests locally, I got 0 failures. ![image](https://user-images.githubusercontent.com/16113997/196376627-8c342a05-63d7-4005-8eff-1eb234cdce1c.png)

From the product model, `unit_value` is only validated when the variant unit (unit size) is selected. ```ruby validates :unit_value, presence: { if: ->(p) { %w(weight volume).include? p.variant_unit } } ```...

Hi @withshubh can you assign this to me :)

Hi As the rendering options will persist after the logout, I was thinking about adding a new model to store the rendering options. What do you think? ```ruby ReportRenderingOptions report_type:...