Product creation minor improvements

[abdellani]

What? Why?

Closes #9298

• [x] remove red star on Tax category
• [x] remove red star on Supplier
• [x] remove the option to select a blank 'unit size' in the dropdown
• [x] Add red highlighting and little text 'can't be blank' under the field: unit size
• [x] Add red highlighting and little text 'can't be blank' under the field: unit value
• [x] Add red highlighting and little text 'can't be blank' under the field: product category
• [ ] Add "unit value" in the content of the red box at the top of the page

What should we test?

• same steps as in https://github.com/openfoodfoundation/openfoodnetwork/issues/9298#issue-1268100585

Release notes

Changelog Category: User facing changes | Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[abdellani]

For the last task, I think that it's not possible with the current validation in the product model.

[drummer83]

@abdellani Wow, that's amazing already! I propose to go for the pull request without that last part. We would need to do some inception work to define how that should look like.

[abdellani]

@drummer83 the PR is ready then :)

[drummer83]

Alright, I have moved it to Code Review. Our developers will have a look and let you know. This will probably not happen until next week though.Feel free to pick up another issue in the meantime! Thanks for your contribution, @abdellani! :blush:

[abdellani]

@mkllnk
Can you please provide more details? Am I supposed to write new tests? or just add some assertions in the existing tests?

[sigmundpetersen]

What Maikel mentions is part of our delivery process, described here

The PR is moved on to manual test by our testing team after it is approved in code review.

You can follow the pipeline by installing the Zenhub extension or (I think) you can look at the board at this link https://app.zenhub.com/workspaces/dev-pipe-54b840c6a249c8781446d4b2/board

[RachL]

@abdellani no don't worry it just means that Maikel has move the issue to the "test ready" column of our board (you can see it by activating the Zenhub extension on you browser). Our testing team will have a look and comment here before final merge :+1: Many thanks for your contribution!

[sigmundpetersen]

Double posting there 😉 Thanks @RachL

[RachL]

haha @sigmundpetersen was faster...as always :)

[drummer83]

Hi @abdellani,

Thank you for this pull request! I have staged it on one of our servers and did some manual testing. Here are my results.

Initial view:

• remove red star on Tax category :heavy_check_mark:

• remove red star on Supplier :heavy_check_mark:

• remove the option to select a blank 'unit size' in the dropdown :heavy_check_mark:

Submitting a blank form:

• Add red highlighting and little text 'can't be blank' under the field: unit size :heavy_check_mark:
• Add red highlighting and little text 'can't be blank' under the field: product category :heavy_check_mark:
• Add "unit value" in the content of the red box at the top of the page :x: --> this was decided to keep out of this PR :heavy_check_mark:

Submitting a form with unit size selected but no unit value:

• Add red highlighting and little text 'can't be blank' under the field: unit value :heavy_check_mark:

Everything you did is looking great, thanks again. I couldn't spot any regressions so I will move this to 'ready to go'! :rocket:

I you feel like continuing your great work on this page, I will create a wishlist item with a few little remaining things (probably later today). :arrow_right: #9834