Feng Yu comments

Results 162 comments of


Feng Yu

fix: get correct env from npm config

> Can we add a test for this? I don't know how to add this test case. Because `npm config set FOO BAR`should execute before test. If we add this...

fix: get correct env from npm config

> Can we add a test for this? I try to add a simple unit test for this. You can review again. Thanks.

fix: get correct env from npm config

Hi @marktnoonan . Please review my PR and let me know if I lost something. Thanks.

Add option to ignore Desktop file error ?

But seems `SingleMainWindow` is valid since `1.5`: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html Would you please upgrade the Desktop file spec ?

How to add other elasticsearch plugins?

Thanks. The `ik` is a Chinese Word Segmentation plugin for elasticsearch. The grails plugin elasticsearch has a local mode for development. Is there any way to let local mode install...

mingw64 build failed: relocation truncated to fit: R_X86_64_32S against undefined symbol `functable@tpoff'

> It's finding `libz.a` in place where it's not supposed to be... When building zlib-ng, you can't have for example zlib development package installed. Thanks. I try to find `libz.a`...

mingw64 build failed: relocation truncated to fit: R_X86_64_32S against undefined symbol `functable@tpoff'

And I can reproduce this issue in a fresh Ubuntu image: ```sh docker run --rm -it ubuntu ``` In ubuntu container: ```sh apt update apt install -y wget make wget...

mingw64 build failed: relocation truncated to fit: R_X86_64_32S against undefined symbol `functable@tpoff'

> Does CMake work? Could you please show me an example ? I don't know how to use cmake for cross compiling.

mingw64 build failed: relocation truncated to fit: R_X86_64_32S against undefined symbol `functable@tpoff'

I try to use cmake. But still this issue: ```sh cmake . -DZLIB_COMPAT=on -DCMAKE_EXE_LINKER_FLAGS=-static -DCMAKE_C_COMPILER=/opt/x86_64-w64-mingw32-cross/bin/x86_64-w64-mingw32-gcc -DCMAKE_CXX_COMPILER=/opt/x86_64-w64-mingw32-cross/bin/x86_64-w64-mingw32-g++ -DCMAKE_SYSTEM_NAME=Windows -DCMAKE_SYSTEM_PROCESSOR=x86_64 -DCMAKE_SYSROOT=/opt/x86_64-w64-mingw32-cross/ cmake --build . --config Release ``` Output: ``` -- The following...

mingw64 build failed: relocation truncated to fit: R_X86_64_32S against undefined symbol `functable@tpoff'

Sure: `./configure` output: ``` # CHOST=/opt/x86_64-w64-mingw32-cross/bin/x86_64-w64-mingw32 ./configure --static --zlib-compat Using /opt/x86_64-w64-mingw32-cross/bin/x86_64-w64-mingw32-ar Using /opt/x86_64-w64-mingw32-cross/bin/x86_64-w64-mingw32-ranlib Checking for compiler... /opt/x86_64-w64-mingw32-cross/bin/x86_64-w64-mingw32-gcc Building static library libz.a version 1.2.13.zlib-ng with /opt/x86_64-w64-mingw32-cross/bin/x86_64-w64-mingw32-gcc. Checking for off64_t... Yes. Checking...