cypress icon indicating copy to clipboard operation
cypress copied to clipboard

fix: get correct env from npm config

Open abcfy2 opened this issue 1 year ago • 5 comments

npm config set VAR VAL will inject npm_config_var=val environment variable. This commit will solve this issue

Closes: #24556

abcfy2 avatar Nov 13 '22 16:11 abcfy2

Thanks for taking the time to open a PR!

cypress-bot[bot] avatar Nov 13 '22 16:11 cypress-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 13 '22 16:11 CLAassistant

Can we add a test for this?

I don't know how to add this test case. Because npm config set FOO BARshould execute before test.

If we add this command in unit test, then we should execute this test in sub process.

abcfy2 avatar Nov 17 '22 02:11 abcfy2

Can we add a test for this?

I try to add a simple unit test for this. You can review again. Thanks.

abcfy2 avatar Nov 17 '22 03:11 abcfy2

Hi @marktnoonan . Please review my PR and let me know if I lost something. Thanks.

abcfy2 avatar Nov 28 '22 13:11 abcfy2

Yay a green build, @abcfy2 thanks for the PR and being patient while i got the build fixed!

mjhenkes avatar Dec 01 '22 21:12 mjhenkes