cypress
cypress copied to clipboard
fix: get correct env from npm config
npm config set VAR VAL
will inject npm_config_var=val
environment variable. This commit will solve this issue
Closes: #24556
Thanks for taking the time to open a PR!
- Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
- Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.
Can we add a test for this?
I don't know how to add this test case. Because npm config set FOO BAR
should execute before test.
If we add this command in unit test, then we should execute this test in sub process.
Can we add a test for this?
I try to add a simple unit test for this. You can review again. Thanks.
Hi @marktnoonan . Please review my PR and let me know if I lost something. Thanks.
Yay a green build, @abcfy2 thanks for the PR and being patient while i got the build fixed!