Andrew Bayer comments

Results 246 comments of


                                            Andrew Bayer

Clean up Regexes

fwiw, I've verified locally that the `Pipeline` in examples/v1beta1/alpha/pipelinerun-param-array-indexing.yaml fails validation. So yeah, there's an issue. =)

Ok, I took your branch and added this as a test case to `pkg/apis/pipeline/v1beta1/pipeline_validation_test.go`'s `TestValidatePipelineParameterVariables` test: ``` { name: "array index param - using the value of an array index...

Clean up Regexes

/approve cancel

Rely on knative/pkg to update TaskRuns

/retest

`git-init` should specify to run as root when it needs it.

/reopen I think we need a fix that doesn't require `runAsUser: 0` - we're going to break anyone using `git-init` directly as soon as they bump that to `v0.35.0`. Yeah,...

`git-init` should specify to run as root when it needs it.

/priority important-soon

`git-init` should specify to run as root when it needs it.

/remove-priority important-longterm

`git-init` should specify to run as root when it needs it.

So my immediate question is whether we think there's enough usage of `git-init:latest` out there in the wild to merit reverting the base image change ASAP. I've verified that all...

`git-init` should specify to run as root when it needs it.

I just did a local run with `ghcr.io/distroless/git:root` as the base, then ran `examples/v1beta1/pipelineruns/pipelinerun.yaml` without `runAsUser: 0` in my kind setup, and it worked. (just to be safe, I did...

`git-init` should specify to run as root when it needs it.

Not sure what you mean by "that" - if you mean switching to `:root` and removing the `runAsUser: 0`s from the various YAML files they were added to, then yes?...