abaevbog
abaevbog
@dstillman as followup to this discussion https://forums.zotero.org/discussion/comment/469722/#Comment_469722 I rebased this PR to make the sidenav navigatable via keyboard (+ added notes context list navigation)
Most importantly, there is the "Locate" button that was moved into the sidebar that one needs to get to somehow. I also assumed that plugins would add their own sidebar...
@dstillman, I went over the `onclick` behavior for the grouped buttons and changed it to just do nothing when `itemDetails` is already visible. I intentionally kept it to not change...
Hm, but I guess it might still be worth it to move focus into the tab but only when a new tab is selected, now that I am trying it...
But then, I'm afraid, we would end up doing exactly what we were fixing in https://github.com/zotero/zotero/pull/4069... In scaffold, focus would go into the tab when tab selection changed and it...
Gotcha, yeah, navigating in/out of the sidenav does take some time. I suppose scaffold was really a bit more of an issue issue, since arrows don't just move focus but...
> Since you're selecting the buttons as a group, should it not focus the whole item pane, so you can scroll, rather than just the first section? We could! I...
Focusing the scrollable area seems quite nice actually! I added "Item Details" label to it - same as to the grouped buttons in the sidenav. Correct me if there's a...
Great! I added a separate PR to address those remaining issues.