abaevbog

Results 268 comments of abaevbog

For this to not break syncing, allowed predicates in [dataserver](https://github.com/zotero/dataserver/blob/172584aa38a17a7e6ecca51e2bbc25b00450fad9/model/Relations.inc.php#L33) would need to be updated to include `zotero:primaryAttachment`

Re notes from https://github.com/zotero/zotero/issues/1715#issuecomment-2656154267: > Let's rebase this. (I did, but I can't push due to Git LFS changes since the last commit. Not sure if there's a setting in...

> So instead of special handling of the primary attachment, we should probably move the best attachment to the top. The natural issue with that is getBestAttachment() talks to the...

This is great! I think the keyboard shortcuts approach we took is quite intuitive and in general everything does work quite well. A few minor things I paid attention to...

> However, if the annotation is selected with the mouse, you still need to be able to move it. Allowing movement in both modes (focus and selection) would be weird....

This is great! This collection of shortcuts feels very good to me - arrows feel right to move objects around and Shift(+Cmd)+Arrows does fit well underline and highlight, since it's...

Awesome! There are some tiny conflicts in https://github.com/zotero/reader/pull/137 now (nothing major). I assume it's best for me wait for the EPUB before resolving, in case we have some additional conflicts...

The issue I am now seeing with making all buttons in the sidebar focusable is that all buttons that scroll the itemPane on click don't make much sense when announced...

https://forums.zotero.org/discussion/comment/469728/#Comment_469728