abaevbog

Advanced search test gave me some trouble during initial upgrade to react 18 as well but on the earlier `waitForWindow` stage. I can reproduce this locally on every fourth or...

@mrtcode, I am working on rebasing this and making sure it's all working with the new EPUB navigation. I ran into a fresh issue after recent changes. When the search...

> I'm wondering, what's the best way to get which part of the text layer corresponds to the highlight annotation for the current search result now? Something that got me...

> But I assumed this._findState.result.annotation would point at the current search result as a fake "annotation" but instead it seems to point at ... some other piece of text on...

With these changes, I believe we get the desired behavior across all main screen readers. Let me briefly summarize these changes, because I slightly revised my initial approach after more...

Great! That would be quite helpful I think, since now you get 3-4 full words, which may not be enough to get an idea where the search result is. If...

> I can’t reproduce aria-labels being “off by one” – it should always be (pageIndex + 1) I went through a few more PDF from my library, and that is...

@mrtcode thank you! This is great, the labels are now consistent and everything is matching for me. I pushed a small tweak to include the current snippet as a `currentSnippet`...

Great! @AbeJellinek do the EPUB changes look alright to you?

@AbeJellinek I rebased this to resolved a few minor conflicts in `dom-view` with the smaller fixes to issues you pointed out earlier. How is it looking to you now?