Andy Babic

Results 149 comments of Andy Babic

A few of questions, if anyone can help: **Audit logs**: If you're actioning something for a proxy model instance, you're really actioning something for the concrete object and all/any proxy...

@chosak it looks like the migration in that PR would remove the need for developers to run a separate script/management command to set up the `ContentType` and `Permission` objects, which...

@chosak Thinking on this some more, I think we could combine the `ContentType` / `Permission` creation logic and the "getting a content type without accidentally creating one" into a single...

@arthurio. Congrats on the contribution. That issue had quite the history! Props for getting stuck in and seeing it through. I should be able to get a PR submitted for...

@arthurio @chosak I've posted some initial workings in wagtail/wagtail#5003, if you'd like to see how things are coming along. It's early days, but any thoughts or feedback would be greatly...

Thanks for the feedback @arthurio! > I'm fairly sure it's not true since Django 1.11. If you have django.contrib.contenttypes in your INSTALLED_APPS, create_contenttypes will be called after each migrate Oh,...

> You could update the script to only look at the wagtail models but it could be hard if someone mixes up wagtail models and others in the same app....

FYI, I've updated the issue description with the most up-to-date implementation recommendations, so that it's clearer to see what is being proposed.

Thanks for the keen eyes @arthurio! Sorted now.