Andy Babic

Results 149 comments of Andy Babic

@RealOrangeOne You may find `wagtail.coreutils.get_dummy_request()` useful here :)

@RealOrangeOne was just looking at this again in the context of some menu generation issues we had recently on a client project, and wondered if `wagtailpagecache` might be over-complicating things...

@RealOrangeOne I was thinking about this from the context of adoption, and making it feel more like a natural replacement for the Django version, and had a couple of thoughts:...

Coolio. Happy to take your lead on the tag naming 😃

The only outstanding thing from my perspective is moving the cache-related stuff out of `wagtailcore_tags.py` and into a new module. The rest was 🥇

Thanks for the updates @RealOrangeOne. I may have some time this Monday or Tuesday to give this a test run, but I do have a new project kicking off this...

Here are the things I plan to do to make this safer: - Add a `WAGTAIL_LOCALEMANAGER_MAX_CACHE_AGE` setting to control how long any running instance of the app should trust data...

@gasman I personally don't think that switching from a database connection to a cache service connection (in 99% of cases) is a worthwhile swap - not when taking into account...

> Sounds like a lot of over-engineering to me I would argue that the addition `referesh_cache()` simplifies things if anything, and the introduction of `WAGTAIL_LOCALEMANAGER_MAX_CACHE_AGE` feels like pretty standard practice...

@gasman Okay, that's fair enough. What if we did this without the settings, and just caveated the docs for the following to outline that return values are fine for things...