Andy Babic

Results 149 comments of Andy Babic

@thibaudcolas I believe I've addressed all of your feedback now, so this is ready to look at once more.

@cam-yates that's really useful feedback. Thanks for trying this out!

Hi folks. Although github says there are no conflicts here, `main` has since undergone a major restructuring of panel code, so am in the process of reworking this to fit....

Thanks @tomdyson! I'm actually struggling to figure out how I had `read_only_for_update` working properly before, as there doesn't appear to be anywhere where I have access to the panel instance...

These changes will be folded into #9244, where tests will also be included

One change I'd like to make before adding tests is: Using (the same) `Filter` objects the whole way through, instead of just spec strings, as I think that may make...

For anyone interested in testing this, I have submitted some code to the `bakerydemo` repo which calls this method to generate multiple renditions and render them to a template: https://github.com/wagtail/bakerydemo/pull/367...

@gasman I've just realised `find_existing_rendition()` isn't used in the new rendition process, so restoring the documentation isn't really enough here. I think what we need to do for now is:...

@gasman Okay, this design is now something I'm a bit happier with.... I have broken down `get_renditions()` in a similar way to `get_rendition()`... with most of the custom code moving...