Aymeric Augustin

Results 368 comments of Aymeric Augustin

I see, you want to blacklist the github username rather than the trac username. You can go ahead with this idea.

Hello - thank you for working on this. I found this issue because fuzzing for websockets stopped working when I dropped support for Python 3.8, which is now EOL. I...

> Our main concern with any kind of upgrade is causing new build failures for existing projects. I hear you; however, you're probably reaching the point where you're causing more...

> Do you have links to / PRs for these patches? There's here: https://github.com/google/oss-fuzz/pull/12027#issuecomment-2314118556

My opinion is mainly "let's not get too fancy, or else someone is going to complain that it doesn't work in their APM / ..."

I've never seen the pattern of removing the traceback in 18 years of building software in Python so I'm worried that it may have consequences that we would regret.

I looked into this over the weekend and I've grown sympathetic to your position. I started standardizing on "all DEBUG and ERROR logs have tracebacks; none of the INFO and...

The double log is an interesting idea. To be honest I was planning to keep it simple; if it crashes, just `connect` (instead of using the magic reconnect) and see...

I meant "if I do simple INFO logging without traceback and a user wants the traceback, they can get the traceback by calling `await connect(...)` instead of `async for ......

I took a quick stab at fixing it. I'm leaving it there for tonight; I'll review my own PR later :-) Meanwhile, happy to get your feedback.