André A. Gomes

Results 477 comments of André A. Gomes

Obs: - In commit 53aca2d23 there are changes that seem orthogonal to its description (namely changes to `small-web`); - Commits like 3c368fb4d, 0acb67334 or a0cbde45c should always be squashed in...

A very welcomed change! Now I'm going to test this. I didn't use `auto-mode` before, so I need some time to get used to it :)

> I don't see them being much of a problem It's not a problem at all, it's just easier on the reviewers!

I believe you still haven't deprecated the `rememberable-p` slot from `mode`, correct?

Please review `toggle-modes`, `https->http-loop-help` and the `config-fails-and-browser-restarts` test.

In the docstrings and symbol names you seem to mix and match "previous" and "last", as well as "page" and "url". When referring to "last URL", it might perhaps be...

I've left some minor comments as requested. Overall I trust your judgement, since I don't have the big picture that you have, @aartaka.

I can report it, but I'm still trying to investigate it a bit on Guix by running: ``` ./pre-inst-env guix build $(./pre-inst-env guix refresh -l sbcl | cut -d ':'...

I found out that `maxima` doesn't compile as well with the latest `sbcl` version. That means that the issue doesn't come from `cffi`. I guess I'll drop an email in...

@hendursaga could you try to build `nyxt` with the latest `sbcl` commit?