André A. Gomes
André A. Gomes
I don't understand how can I mark as resolved the changes that @aartaka requested, without dismissing his review. Can we use less GitHub paraphernalia? It gets in the way.
> I feel like lost and not remembering anything about the recent changes in this PR, but one thing I'm sure: changelog is better off staying as it is, because...
> I don't understand the logic of this statement. 3.0.0 comes after 3-pre-release-1 (chronologically), so why say that 3-pre-release-1 comes after 3.0.0? Correct. I should have said that it makes...
> Yes, they won't be there in 3.0.0, but it's nice to keep track of separate releases while we're doing them! Agree. Any tagged release should have a corresponding changelog...
> Are we lying to ourselves about the existence of 3-pre-release-1? I don't know what to believe anymore... I'm not sure what you're expressing here. I was suggesting that commit...
Ready to merge from my side.
All addressed @aartaka. I just left the word "Konkeror" out of the changelog. Ok to merge?
Ok! Notice that the tests failed due to [this commit](https://github.com/atlas-engineer/nyxt/commit/38906b3e960c7c531fa90f27c53ee570040bfe1b#commitcomment-81930387).
Merged via a0f9f77ae.
I thought about this too. It would be nice to have an assertion that would `mapcar` `string=` for lists, as it's quite common as well. But this would need to...