Andreas Adelmann
Andreas Adelmann
A few thoughts to 1: a) we get stuck in a destructor can you add prints in Ippl::finalize()? `void finalize() { Comm->deleteAllBuffers(); Kokkos::finalize(); // we must first delete the communicator...
closes #415
Victor thanks for the PR. If you did not have done already, could I ask you to pull the master into #350? Thanks!!
- PICnd is running fine - ParticleSendRecv - ExecSpace does not work for AMD at the moment.
If I remove ExecSpace, PIC and ORB are working
Why did you add the plot's? In general pdfs of results should not be in the repo. Are these plots used in your thesis?
uups my accept was a mistake, need to revert
When updating we also need to enforce the rules qualifying for being on the author list. Proposal: A contributor to IPPL is a individual that have made significant contributions to...