Ishan

Results 9 comments of Ishan

@MateusStano Please review this PR. All tests passing except pylint but I think that is not from the 3 dof commits. Tests for 3 dof are not included. Please check...

@Gui-FernandesBR I have held discussions about tests with @MateusStano and we think it should be a separate PR along with the documentation. Would be easier to manage otherwise this PR...

> The PR looks good. Main points missing for me that could be easily appended to a following PR: > > 1. There are still no "sanity-check" tests for the...

@Gui-FernandesBR @phmbressan Here is a comparison of results of 3 dof and 6 dof on bella lui rocket example. as expected the impact/landing point is drastically incorrect. This is expected...

Results with preliminary weathercocking implementation and creating quasistatic attitude variation for 3 dof : termination at apogee :- termination at apogee false : -

@copilot Please check if the fixtures from flight_fixtures.py can be reused for these tests or not. If yes then reuse them here. If not then add new fixtures to the...

@copilot Pointmassrocket and pointmassmotor are avialable in the base branch as well as the branch you have created. They should be utlised here for 3 dof flight accpetance tests. As...

@copilot The tolerances related to weathercocking are not realistic. The changes in flight trajectory due to weathercoking are hard to quantify on, instead of checking for tolerances there, we should...

> @aZira371 is this PR ready for review? Yes @Gui-FernandesBR it is ready for review. I have some doubts and questions but I think those we can discuss via a...