Amir Alavi
Amir Alavi
That's a good idea, thanks @vie-serendipity !
/ok-to-test
Hi @bingzheliu awesome job with the Issue summary 👏🏼 We have a duplicate Issue here as well: https://github.com/kubernetes-sigs/descheduler/issues/1032
Fixed in #1412 - we'll work on getting a v0.30.1 out in the next week or so
I may have tagged the release incorrectly. cc: @damemi
Yes, I followed those steps. Looks like Descheduler version parsing broke in this commit https://github.com/kubernetes-sigs/descheduler/commit/dca2e58b8e705ad60b3c060f541e9d0a43238fe0 I can submit a fix soon
fixed in #1430 /close
> One thing that I was thinking: should this key really be supported on `v1alpha1`? I ended up doing it for the sake of consistency between both versions, but I...
@tioxy would you please add a unit and/or e2e test for this to verify that it's working as expected? Thank you!
@ingvagabund your call, but happy to merge this as-is. Given that we're removing the code, this new addition will also be removed. /approve /hold for Jan's final review