Amir Alavi comments

Results 236 comments of


                                            Amir Alavi

feat: Add namespace override settings in Helm Chart

/assign @jklaw90 seems fine to me, any thoughts?

chore: add required service when serviceMonitor is enabled

/ok-to-test

Enhance Descheduler Metrics to Include Specific Arg(Rule) Violation Details

Hi @Colvin-Y In this example, can you not use two separate Profile with meaningful names? Profile name is included in logs and `descheduler_pods_evicted` metric https://github.com/kubernetes-sigs/descheduler/blob/d34848086cd4f7123383bdaddbcaccf0353e8b94/metrics/metrics.go#L34-L39

The descheduler supports limiting the total number of pods evicted per rescheduling cycle

seems reasonable to me. cc: @damemi and @ingvagabund thoughts?

Poor defaults in Helm chart

Hi @jgillich thanks for the feedback! Please find my response below: >A lot of strategies are enabled by default. This issue goes away once we move to v1alpha2 in this...

Single node clusters support

/assign

add GOMAXPROCS limit

/ok-to-test

add GOMAXPROCS limit

/retest-required

[ClientConnection] e2e: build a descheduler image and run the descheduler as a pod

/ok-to-test

feat: add pod succeeded to podlifetime allowed states

@buroa have you tested this? `PodLifeTime` strategy lists pods on a node and I'm not 100% certain if pods in phase `Succeeded` will be returned. If you already have tested,...