Alexandre Detiste

Results 162 comments of Alexandre Detiste

Can you rebase ? Looks good.

I need to test this on Buster

It looks like a case of too early optimisation on both sides. It was a big mistake on my side to optimize for a match, I should have instead optimized...

Hi, there is `/etc/cruft/ignore`as hinted in the manual. As the commit says https://github.com/a-detiste/cruft-ng/commit/146b645d250f2b17fa40b3ca1dcb2f3ea2d38976 : `support for empty flatpak install` . /usr/share/cruft/ignore is a example/reference file with some tools that lists...

If you want I can also review the reminder of the non-flatpak matches (mosting missing rules)

Thanks for the review The right thing to do is to get rid of INTEGER_TYPES altogether: ``` -if type(commandTypeOrEvent) in INTEGER_TYPES: +if isintance(commandTypeOrEvent, int): ```

I m on Holliday. Anyone can cherrypick the first commit that removes py2.6< compatibility if it tastes them, I ll redo this work in smaller pieces when I get back.

At first there was only this one first commit untill I got asked to proceed further

The PR against GRASS (which uses Wx by the way) had a similar +/- size and went in smoothly. I m not scared. What do we need to go further...