Phoenix icon indicating copy to clipboard operation
Phoenix copied to clipboard

remove Python2 hybridation code

Open a-detiste opened this issue 1 year ago • 7 comments

print() is available since Python 2.6

https://wiki.debian.org/Python3-six-removal

a-detiste avatar Mar 20 '24 13:03 a-detiste

Thanks for the review

The right thing to do is to get rid of INTEGER_TYPES altogether:

-if type(commandTypeOrEvent) in INTEGER_TYPES:
+if isintance(commandTypeOrEvent, int):

a-detiste avatar Mar 29 '24 13:03 a-detiste

I agree with this PR. I also agree with removing all six usage.

jmoraleda avatar May 17 '24 18:05 jmoraleda

I agree with dropping support for Python 2. IMHO, this PR is too aggressive and the first commit (removing print_) would be more acceptable if it was a separate PR.

From "https://wxpython.org/pages/contributor-guide/", 5. Do not put more than one fix/feature in the same branch or PR. Make a new distinct branch and PR for each of them.

komoto48g avatar Jul 12 '24 16:07 komoto48g

I m on Holliday. Anyone can cherrypick the first commit that removes py2.6< compatibility if it tastes them, I ll redo this work in smaller pieces when I get back.

a-detiste avatar Jul 12 '24 16:07 a-detiste

At first there was only this one first commit untill I got asked to proceed further

a-detiste avatar Jul 12 '24 16:07 a-detiste

Please merge.

newville avatar Aug 05 '24 00:08 newville

The PR against GRASS (which uses Wx by the way) had a similar +/- size and went in smoothly. I m not scared. What do we need to go further ?

a-detiste avatar Aug 10 '24 22:08 a-detiste