Peter Hill

Results 527 comments of Peter Hill

Relicensing BOUT++ is a no-go for various reasons, I'm afraid. Probably most of the stuff I mentioned would need some rewriting at least to fit into plasmapy, so it may...

CI failing because `-lnetCDF::netcdf` is getting into `bout-config` via `SetupBOUTThirdParty.cmake`, probably: https://github.com/boutproject/BOUT-dev/blob/a628ec012859db7de7d5b7743ad9a8760044e0fe/cmake/SetupBOUTThirdParty.cmake#L174 Likely because newer Ubuntu version is supplying `netCDFConfig.cmake` and setting things differently than we expect. Not a major...

@ocefpaf Would it help to change `ghcr.io/ocefpaf/manylinux2014_x86_64-netcdf` to use `FROM ghcr.io/h5py/manylinux2014_x86_64-hdf5` and explicitly build on top of the h5py manylinux image? I don't think that would _guarantee_ compatibility, as that...

Ah, that's a shame they weren't interested. This is a really hard community problem. I've not actually been able to find any real differences between the built `.so`s, and in...

The problem is specifically that when `auto_complex=True` and a variable has a complex dimension, then we discard that from `var.dimensions`, which is now it gets the shape wrong in the...

> I just wanted to let you know that that is essentially what I did for sheath_parallel: https://github.com/dschwoerer/hermes-3/blob/fci-auto-with-debug/src/sheath_boundary_parallel.cxx#L226 in a way that lets you do both FCI and non-FCI in...

I've added a similar test for the insulating BC, along with a bug fix

Benchmark is failing because the PR is from a fork and so doesn't have push permissions

This will also fix the docs not building most of the API: https://easyvvuq.readthedocs.io/en/dev/py-modindex.html