Peter Hill

Results 428 comments of Peter Hill

I'm also looking at using `fparser` for `ford` -- I think that would help with https://github.com/Fortran-FOSS-Programmers/ford/issues/405 too. There's still some f2008 features it doesn't support yet either, but I'm already...

Unfortunately the parser in ford is very tightly coupled to the other parts, so swapping it out for something else would require some work. But I do think it would...

Hi @pajlada, getting clang-tidy-review working nicely with forks would be really great! Is perhaps a third way to use [annotations](https://github.com/orgs/community/discussions/26703) instead of comments? It looks like that would be limited...

While that sort of split using switches to control output vs posting would work, my main worry is the time and resource use. This is a docker action, and it...

Oh dear, that's not supposed to happen! Unfortunately I won't have chance to look at this for at least a couple of weeks, but if you figure it out, I...

That's a very odd suggestion! My suspicion is that it's due to that header file requiring Qt's moc. I'm not sure how you should best handle that -- maybe either...

I thought it only applied to the headers? At any rate, I'm afraid I think this is an issue between clang-tidy and Qt -- you would have the same issue...

Ah, ok! Interesting that those are also different warnings from clang-tidy-review Could you re-run it with `--export-fixes=clang-tidy-fixes.yaml` and post the resulting yaml file?

It looks like maybe `clang-tidy-review` is reading the fixes file wrong, maybe an off-by-one error somehow. I need to find some time to reproduce your setup and get the actual...

Looks like the emitted diagnostic is: ``` { 'DiagnosticName': 'readability-function-cognitive-complexity', 'DiagnosticMessage': { 'Message': "function 'textAroundOffset' has cognitive complexity of 31 (threshold 25)", 'FilePath': '/github/workspace/src/TAccessibleTextEdit.cpp', 'FileOffset': 13337, 'Replacements': []}, 'Notes': [...