Peter Hill comments

Results 527 comments of


                                            Peter Hill

Consume and export Common Package Specification

Ah, I see what you mean. I think that could in principle be handled by [`configurations`](https://cps-org.github.io/cps/configurations.html), but that's maybe not so ideal. I think this is supposed to be handled...

We should have clang-format in CI

We have this in BOUT++: https://github.com/boutproject/BOUT-dev/blob/master/.github/workflows/clang-format.yml There is a small downside: running this in PRs can hide test failures, which is a bit annoying. The other options are to run...

diff size should consider deletions

Looks like the error is actually coming from Github when we ask for the diff of the PR -- that is, we don't care how big the PR is, but...

Integration with Sphinx

I think there's basically two parts to getting this working: 1. Creating a set of Sphinx classes for rendering the docs - This would let users manually write docs in...

Integration with Sphinx

@jalvesz @clatim if you're still interested in this, please get in touch and we'll set up a call about how best to go about this :)

Integration with Sphinx

Awesome!

Allow exclusion of this/self

I think this should be possible, but we'd need to look up the bound procedure to see if it has `pass`/`nopass` on it.

feat: Add `Level::None` for omitting the header

I have a practically identical change in #159 for very similar reasons :)

Run the examples in CI

Launching them with `solver:nout=1 solver:timestep=1` will do the minimal thing that hits all parts

WIP: Control access to state variables in transform method

Does this now include #399? Is that on purpose?