Zac Sweers

Results 342 issues of Zac Sweers

https://issuetracker.google.com/issues/141132765 TL;DR - Every shared element transition leaks the view that was used in the transition, which means at least that view is leaked after detach and likely also that...

status: help wanted
type: leak

It runs on ASTs, so it can run in parallel to compilation. As a potential followup, we can maybe look at making lint optionally run as an implicit concurrent action...

enhancement
help wanted

Error-prone itself has some checks for this, but nullaway is obviously better at it. Given an error like this ``` /Users/zsweers/dev/slack/restructure/slack-android-ng/libraries/foundation/slack-commons/src/main/java/slack/commons/logger/DebugLogger.java:62: error: [NullAway] parameter tag is @NonNull, but parameter in...

enhancement
longterm

These are common in tests ```java assertThat(foo).isNotNull(); foo.bar(); //

The previous color no longer matches the Java branding colors and hasn't aged well. This matches the newer branding Before: `#b07219` After: `#2a6277` ![image](https://user-images.githubusercontent.com/1361086/119438017-407ae900-bced-11eb-8fea-f13419a1001b.png) ## Checklist: - [ ] **I...

Blocked

If [compound extensions](https://discuss.kotlinlang.org/t/compound-extension/10722/1) do make their way into Kotlin, we could leverage them nicely in AutoDispose to do something like this: ```kotlin fun ScopeProvider.Observable.autoDispose() { // ... } fun test(scope:...

Enhancement
On Hold
Kotlin

Gives us a lot more coverage and ensures they're kept at parity, as well as avoiding duplication.

Help wanted
Static analysis

Resolves #39 Resolves #97 (hopefully) Resolves #59 (hopefully) Very much a work in progress. This replaces the current StorageBackedService approach with androidx.paging's solution instead. Part of this will require more...