linguist
linguist copied to clipboard
Improve the Java language color + match modern branding
The previous color no longer matches the Java branding colors and hasn't aged well. This matches the newer branding
Before: #b07219
After: #2a6277
Checklist:
-
[ ] I am associating a language with a new file extension.
- [ ] The new extension is used in hundreds of repositories on GitHub.com
- Search results for each extension:
- https://github.com/search?utf8=%E2%9C%93&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack
- Search results for each extension:
- [ ] I have included a real-world usage sample for all extensions added in this PR:
- Sample source(s):
- [URL to each sample source, if applicable]
- Sample license(s):
- Sample source(s):
- [ ] I have included a change to the heuristics to distinguish my language from others using the same extension.
- [ ] The new extension is used in hundreds of repositories on GitHub.com
-
[ ] I am adding a new language.
- [ ] The extension of the new language is used in hundreds of repositories on GitHub.com.
- Search results for each extension:
- https://github.com/search?utf8=%E2%9C%93&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack
- Search results for each extension:
- [ ] I have included a real-world usage sample for all extensions added in this PR:
- Sample source(s):
- [URL to each sample source, if applicable]
- Sample license(s):
- Sample source(s):
- [ ] I have included a syntax highlighting grammar: https://github-lightshow.herokuapp.com/
- [ ] I have updated the heuristics to distinguish my language from others using the same extension.
- [ ] The extension of the new language is used in hundreds of repositories on GitHub.com.
-
[ ] I am fixing a misclassified language
- [ ] I have included a new sample for the misclassified language:
- Sample source(s):
- [URL to each sample source, if applicable]
- Sample license(s):
- Sample source(s):
- [ ] I have included a change to the heuristics to distinguish my language from others using the same extension.
- [ ] I have included a new sample for the misclassified language:
-
[ ] I am changing the source of a syntax highlighting grammar
- Old: https://github-lightshow.herokuapp.com/
- New: https://github-lightshow.herokuapp.com/
-
[ ] I am updating a grammar submodule
-
[ ] I am adding new or changing current functionality
- [ ] I have added or updated the tests for the new or changed functionality.
-
[x] I am changing the color associated with a language
- [ ] I have obtained agreement from the wider language community on this color change.
- I don't know necessarily where to create a wider discussion but happy to post somewhere you recommend!
- https://twitter.com/java
- [ ] I have obtained agreement from the wider language community on this color change.
I don't know necessarily where to create a wider discussion but happy to post somewhere you recommend!
That's kinda your job 😉. As a Java developer, you're more likely to know the best forums for such a discussion than those that maintain a project written in Ruby 😄.
In the case of Java, the colour has been in place for well over nine years so it is especially important to get community buy-in as this will be noticed and almost certainly will bring up complaints, as we've seen the the past for other long-supported languages.
What are the units of consensus and is there a minimum threshold? I've tweeted about this and folks are liking it + bringing their +1's here, but since y'all are the ones that decide it would be helpful to know what you're looking for! My prior context for this was the PR that last updated the Kotlin color, which used the logo as justification #2428
We don't have a numerical threshold. We just need to see overwhelming support for the change from the community in that community's chosen preferred location for such discussions. If anyone objects when the change goes live, they will then be able to reference where the discussion took place and continue it or accept it.
We introduced this requirement a few years ago after a colour change was made based on one person's opinion and it went down like a lead balloon in the overall community. We'd like to prevent this from happening again.
Ultimately, this is a community decision, not a GitHub/Linguist decision, so needs to be in that community's forums etc for the greatest exposure.
Found it, it was Rust's colour change in https://github.com/github/linguist/pull/4319 We don't want that to happen again 😁
That's terrifying. I'll try to find the right avenue for this and report back.
@ZacSweers The color from the given PNG (25 yr anniversary) is actually
#30748c
I think it depends on where you click. I'm still not sure where to find the right resource for this
Could use a color from the OpenJDK logo
It uses #5382a1
, can get it by opening the svg file.
I found this somewhat old logo guidelines document, which talks about a certain "Java Blue": #007396
If this gets enough community support it'll bring Java and Groovy closer to each other again if/when https://github.com/github/linguist/pull/5418 is merged 😁
Is there any update on this? I'd love to see this change on GitHub :tada:
If there is concern about the similarity to Groovy, could use the orange color (#e76f00
) from the OpenJDK logo or orange (Orange: #F8981D
) from the Java logo:
Can get the color from the text of the svg color.
Current Java color: #b07219
Orange color from OpenJDK logo: #e76f00
Blue color from OpenJDK logo: #5382a1
Orange from Java logo: #F8981D
Blue from Java logo: #5382A1
(same as open jdk logo)
For comparison, new Groovy color (#5418 has been merged): #4298b8
@lildude Any update on this one? It's on the second page of PRs so may have flown under your radar.
I don't think there's much to update. There doesn't really seem to be a good resource in the Java community for soliciting formal feedback on this.
I'm reluctant to merge this without a much wider public consultation on the colour change as Java is a very popular language and peeps are quite attached their colours, even if they're not right or up-to-date.
The change in Rust's colour in https://github.com/github/linguist/pull/4319 caused quite a furore which is precisely why we have this requirement now.
Closing this as there's been no progress on establishing a discussion within formal Java community channels. Feel free to open a new PR once this has been done and concensus has been agreed.