Zac Sweers

https://github.com/Kotlin/kotlinx-knit

Integrate kotlin ABI validator

4

We've been burned by this once or twice in the past, probably worth a look https://github.com/Kotlin/binary-compatibility-validator

Add repro case for #1076

1

left as a toe-hold for trying to tackle this in the future

We handle this for functions and can handle them for properties in a similar way.

KType can be more than just parameterized types or typevariable

2

This is kotlin's equivalent of a `Type` and can also just be a regular class. The current `KType.asTypeName()` is in ParameterizedTypeName.kt though, and should probably be generified and moved to...

Set verification group on ktlint tasks

7

Currently tasks are group-less, which means they go on to a "other" catch-all. Would be nice if these could go in the verification group. Happy to send a PR.

Support incremental annotation processing

5

I remember seeing something somewhere that scabbard disables it (though didn't see anything obvious in code about this). Would be good to have the reasons documented and filing an issue...

0.3.0 fails to build with kapt

12

``` > Task :log-sync:kaptReleaseKotlin FAILED [WARN] Issue detected with dagger.internal.codegen.ComponentProcessor. Expected 1 originating source file when generating /Users/zsweers/dev/slack/slack-android-ng/log-sync/build/tmp/kapt3/classes/release/scabbard/full_slack.logsync.di.LogSyncBaseModule.svg, but detected 0: []. SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting...

Scabbard applies itself even when dagger is not present/used

4

This leads to warnings in kapt when it doesn't run ``` warning: The following options were not recognized by any processor: '[scabbard.failOnError, scabbard.outputFormat, kapt.kotlin.generated, dagger.fullBindingGraphValidation]' > Task :calendar-api-model:kaptReleaseKotlin warning: The...

Multiple annotations should be allowed on the same line when construct is a constructor

7

Consider the following example: ```kotlin class Foo @JvmOverloads @SuppressLint("CheckResult") constructor(...) ``` There alternative is basically this ```kotlin class Foo @JvmOverloads @SuppressLint("CheckResult") constructor(...) ``` Which I'm not sure is better. From...