Zachary Groves

Results 12 comments of Zachary Groves

We should probably add a test for this. Similar to the snapshot test for Mariadb: https://github.com/DataDog/dd-trace-py/blob/1.x/tests/contrib/mariadb/test_mariadb.py#L132-L153

Hi Fred, taking over for Yun here. Could you also try just printing out the environment variable value for `DD_TRACE_ENABLED` so we can check all our bases? `enabled = os.getenv("DD_TRACE_ENABLED")`...

That is odd as `DD_TRACE_ENABLED` should directly toggle `tracer.enabled`: https://github.com/DataDog/dd-trace-py/blob/1.x/ddtrace/tracer.py#L195 The only other thing you should be able to do to modify `tracer.enabled` afterwards is calling `configure()`: https://github.com/DataDog/dd-trace-py/blob/1.x/ddtrace/tracer.py#L317 I could...

Hi @ca-simone-chiorazzo for the release notes, I couldn't find a guide (we're working on improving this) but basically: running `reno new ` will create the release note and tell you...

Hi @matroscoe could you please clarify whether or not setting `DD_TRACE_ENABLED` to false fixes the issue for you? Some users have reported it does, although it seems like you reported...

It might be nice to see the same request flamegraph before and after for reference, but looking at the snapshots you can figure it out so just a nit.

Open questions: 1. Does this break gunicorn or gevent since for execution context switching I've only changed `os.fork` to sample before the context change? _No it does not, we don’t...

I think I need to change the system-tests start_span method a bit to get sampling and propagation tests to pass

This parametric system tests run shows we pass all of the sampling test cases this PR should pass (the pr is just this one, but running a system-tests branch that...

Agreed, I saw your change but wasn't sure mine belonged there, after more thought, this seems like the best way.