dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

feat(pymongo): pymongo adding service name config option

Open mawais54013 opened this issue 1 year ago • 1 comments

Description

This will allow the configuration of the service name for the pymongo integration

Checklist

Reviewer Checklist

  • [ ] Title is accurate.
  • [ ] Description motivates each change.
  • [ ] No unnecessary changes were introduced in this PR.
  • [ ] PR cannot be broken up into smaller PRs.
  • [ ] Avoid breaking API changes unless absolutely necessary.
  • [ ] Tests provided or description of manual testing performed is included in the code or PR.
  • [ ] Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • [ ] All relevant GitHub issues are correctly linked.
  • [ ] Backports are identified and tagged with Mergifyio.
  • [ ] Add to milestone.

mawais54013 avatar Aug 05 '22 19:08 mawais54013

We should probably add a test for this. Similar to the snapshot test for Mariadb: https://github.com/DataDog/dd-trace-py/blob/1.x/tests/contrib/mariadb/test_mariadb.py#L132-L153

ZStriker19 avatar Aug 09 '22 14:08 ZStriker19