bruwbird comments

Results 58 comments of


                                            bruwbird

Use the peerswaprpc proto file for shared serialization

Hello @nepet I am considering a policy of using messages generated from `peerswaprpc` for both implementations. I think there will probably be differences in the struct's json tags. For example,...

Use the peerswaprpc proto file for shared serialization

No, this change may affect cln plugin behavior.

Use the peerswaprpc proto file for shared serialization

> All of that being said, as we are close to a release, we might want to wait postpone merging this PR until the transition to the peerswaprc messages is...

Premium

> Asking for opinions: Should we have fine grained configuration to allow for setting certain peers a different premium fee rate? I suppose that would complicate things a lot and...

Premium

> But allow separate premiums for received swap ins and swap outs, including negative values. This will allow managing liquidity among BTC, LBTC and Lightning. It is possible to configure...

Premium

Thanks for the test. Perhaps some of the behavior is a bug. I'll investigate and fix it.

FIXED. > [premium info is missing from the CLN listpeers](https://github.com/ElementsProject/peerswap/pull/264#issuecomment-1912361102) SwapInPremiumRatePPM and SwapInPremiumRatePPM are added to the ListPeers. This is an additional information, we are currently managing the peerswapd and...