peerswap icon indicating copy to clipboard operation
peerswap copied to clipboard

Published 20 hours ago • verified publisher icon ElementsProject

Use the peerswaprpc proto file for shared serialization

Open YusukeShimizu opened this issue 2 years ago • 4 comments
trafficstars

This is for https://github.com/ElementsProject/peerswap/issues/134. This change is the serialization part for peerswapd and the cln-plugin. I use the peerswaprpc proto file for shared serialization.

The following changes will be made.

  • differences in the struct's json tags.
  • short channel id and state for PeerSwapPeerChannel is converted to channel id and active.

YusukeShimizu avatar Aug 31 '23 01:08 YusukeShimizu

I didn't expect anyone to work on this ticket. This is very late right before a release. Are you sure this change has no impact on how things currently behave?

wtogami avatar Aug 31 '23 05:08 wtogami

No, this change may affect cln plugin behavior.

YusukeShimizu avatar Sep 01 '23 04:09 YusukeShimizu

  • We want to do a stable release soon so we don't want to change anything big in the short-term.
  • This will result in API changes.
  • The premium feature will require API changes.
  • So it's best to merge this along with other API changes so other applications don't need to change more than once.

wtogami avatar Sep 01 '23 22:09 wtogami

All of that being said, as we are close to a release, we might want to wait postpone merging this PR until the transition to the peerswaprc messages is fully completed. I do not expect the API to change that much, if at all in the meantime.

I understand the above. I will keep the PR in draft status until merge is available.
Please let me know if there is a proper way to operate it.

YusukeShimizu avatar Sep 05 '23 01:09 YusukeShimizu