Motov Yurii

Results 218 comments of Motov Yurii

So, as far as I understand, the idea is to add validation to project setup script. Currently project uses Copier. I investigated a little and didn't find simple way to...

Sorry for pushing to your branch, it was simpler than explaining this in review.. If you don't like changes, feel free to revert commits or use only part of suggested...

`passlib` was recently replaced with `pwdlib` with Argon2 in FastAPI repository: https://github.com/fastapi/fastapi/pull/13917 So, we should probably be consistent here and also use `pwdlib` in this repo

I think [this suggestion](https://github.com/fastapi/full-stack-fastapi-template/discussions/1370#discussioncomment-10909265) should work: > Try excluding the alembic folder from watch to fix the refresh

@javadzarezadeh, would you like to continue working on this? Or, is anybody up to take this over?

> I'm not too familiar with this codebase. Can you point me to where I can write those tests? You can create an annotated version of the code example from...

> The test is failing with: > > ``` > FAILED tests/test_tutorial/test_relationship_attributes/test_define_relationship_attributes/test_tutorial001_an_py310.py::test_tutorial - sqlalchemy.exc.ArgumentError: Mapper Mapper[Team(team)] could not assemble any primary key columns for mapped table 'team' > ``` >...

@sebastianfym, @thjungers, Could you please check if this works for you? See code in details: **main.py** ```py from sqlmodel import Session, SQLModel, create_engine, select from .hero import Hero from .team...

One more thing - we should probably make those new internal functions private

> Can we push this forward quickly? Why not? Unfortunately it's not so easy.. As I see the plan is: * Wait for Sebastian to validate the idea * When...