Motov Yurii

Results 218 comments of Motov Yurii

@vk496, are you still interested in working on this?

@rasputyashka, thanks for working on this! This feature looks highly requested: https://github.com/fastapi/fastapi-cli/discussions/45 Could you please resolve merge conflicts and add tests? I would then review this PR

We can also run the app as `fastapi run path/to/module.py --app app`. And this way still doesn't work with factory. How about enabling this too? Seems that the following change...

I actually don't see any problem with `--app` option accepting app factory. But, let's wait for third opinion :) I think we can limit this PR to only support `--factory`...

@rasputyashka, could you please update the description to make it simpler for Sebastian to review? You can summarize what is done and what is under the question. Then we could...

I thought a bit more and I think suggested `--app-factory` option is nice solution! And, with `--app-factory` users will not have to specify `--factory` since we already know that it's...

It's up to you, but I would recommend you edit this PR to make it ready to be merged. It can be simple version that only supports `--factory` with `--entrypoint`....

I suppose that's because `index.html` is being cached. To solve this we need to set separate cache strategies for index.html (no-cache) and static assets (long time cache since they have...

Test taken from #1603 ```py from sqlmodel import Field, SQLModel from typing_extensions import Annotated def test_declaration_syntax_1(): class Person1(SQLModel): name: str = Field(primary_key=True) class Person1Final(Person1, table=True): pass def test_declaration_syntax_2(): class Person2(SQLModel):...

Just as an idea: what if we introduce a rule that all `_TScalar_XX` should go before any of `_TCCA[_TXX]`? This way we only need to add 7 overloads for the...