Xuanwo comments

Results 1650 comments of


                                            Xuanwo

Tracking: Support partition write

Closing for https://github.com/icelake-io/icelake/issues/279

Implement append only task writer.

> How did this api used to by compute engines? Let's prioritize making it functional for now and refine the API later.

Implement append only task writer.

Closing for https://github.com/icelake-io/icelake/issues/279

Implement partition summary for mainfest writer.

Closing for https://github.com/icelake-io/icelake/issues/279

iceberg spec requires to store absolute path of file

OpenDAL will normalize all s3 alike services to `s3`, but hdfs and other java implementations not.

iceberg spec requires to store absolute path of file

Closing for https://github.com/icelake-io/icelake/issues/279

discussion: use order_float instead of f32,f64

I'm open with using `order_float`. But here are some edge cases to take care: - The order: [spec said](https://iceberg.apache.org/spec/) we need to use -NaN < -Infinity < -value < -0...

discussion: use order_float instead of f32,f64

> I guess the only solve way is to maintain our own ordered_float. Maybe it's easier to implement `Hash` and `Eq` by our own.

discussion: use order_float instead of f32,f64

Closing for https://github.com/icelake-io/icelake/issues/279

split in_memory module like on_disk

Is this issue preventing us from adding a new feature? If not, I would prefer to address it during the v0.1 polishing stage.