icelake icon indicating copy to clipboard operation
icelake copied to clipboard

Implement partition summary for mainfest writer.

Open liurenjie1024 opened this issue 2 years ago • 3 comments

https://github.com/liurenjie1024/icelake/blob/99d8d92a7cc8a40c86bc1ab84da4798cd89f1f19/src/types/on_disk/manifest_file.rs#L393 https://github.com/icelake-io/icelake/blob/99d8d92a7cc8a40c86bc1ab84da4798cd89f1f19/src/types/on_disk/manifest_file.rs#L393

liurenjie1024 avatar Jul 18 '23 09:07 liurenjie1024

https://iceberg.apache.org/spec/#partitioning:~:text=Partition%20data%20tuple%2C%20schema%20based%20on%20the%20partition%20spec%20output%20using%20partition%20field%20ids%20for%20the%20struct%20field%20ids

This should do after we support partition in data file, I find that this sumary is computed from the partiton in data file.

ZENOTME avatar Jul 20 '23 08:07 ZENOTME

BTW, do we prepare to support partition in 0.1 veriosn? It seems the whole API can build without partition.

ZENOTME avatar Jul 20 '23 08:07 ZENOTME

Yes, it's necessary for practical use.

liurenjie1024 avatar Jul 20 '23 08:07 liurenjie1024

Closing for https://github.com/icelake-io/icelake/issues/279

Xuanwo avatar Jul 09 '24 10:07 Xuanwo