Xuanwo comments

Results 1638 comments of


                                            Xuanwo

fix(core/services/gdrive): Fix gdrive create_dir request: trim trailing `/`

Hi, have you tested locally about this PR? Our CI doesn't cover forked repo.

fix(core/services/gdrive): Fix gdrive create_dir request: trim trailing `/`

> I'm testing right now in https://infoflow.app 's alpha version. Cool!

fix(core/services/gdrive): Fix gdrive create_dir request: trim trailing `/`

Thank you @imWildCat for your efforts—much appreciated.

No way to set resolver or pre-resolved IP address per request.

Hi @seanmonstar, I took a look at this. It appears that `DynResolver` is part of our `HttpConnector`, and making it per-request would require significant changes. Would it be a good...

docs: Explain the meaning of OneDrive access token

Thanks a lot for raising up an issue. I'm going to setup the integration tests for one drive. Maybe I can finish the documentation at the same time. And you...

docs: Explain the meaning of OneDrive access token

Should be addressed by https://github.com/apache/opendal/pull/5733

[gdrive] potential regression of folder name handling

https://github.com/apache/opendal/blob/27c6a776653b7671da8171dea8c36283713eeb45/core/src/services/gdrive/core.rs#L396-L405 Maybe we should trim the `/` suffix for dir?

[gdrive] potential regression of folder name handling

> I also found another issue shown above: opendal now create folder with same names... We should already have checks for the folder exist before creating. Maybe some logic not...

[gdrive] potential regression of folder name handling

> I'm not calling opendal concurrently. The cache is thread-safe, so concurrent calls should not pose a problem. I believe this issue is related to how we handle paths.

[gdrive] potential regression of folder name handling

> @Xuanwo any suggestion on the direction to fix the tests on main first? Hi, I've been quite busy recently. I plan to set aside some time next week to...