Xaver-DaRed
Xaver-DaRed
We have optParams.isKiller optParams.noKiller I have to agree with Teo this logic should be wraped inside a check for both, so it runs once and no more. The onMobDeath logic...
I also have to wonder if we REALLY need to use a server variable for this. Server variables are slow AF and from my experience, sometimes they fail to update...
Several things here: - Synthesis configurations should all remain together. This should go bellow the existing ones. - They should all follow the same naming convention. This should all start...
Partially adressed in #3720
Do we really need a new status effect? Do tomahawk and this stack? Couldnt we just reuse/rework tomahawk status effect to work with this? The amount of status effects is...
Plan was to create a function for this kind of cases (Non-resistable enfeebles) inside enfeeble_spell.lua and add a callback in the spell script, so no actual logic ever resides inside...
> I'll try folding it into the Tomahawk effect. > > For spells that add special enfeebling effects like Banish, Ancient Magic, BLM -Ja spells etc, where/how would you recommend...
I havent forgotten about this. Sorry.
They are named differently because they are different skills that probably need a different script and a different database definition
This PR seems abandoned and the retail data still needs to be confirmed. I'll close it and open a new one (if needed) once I get the captures