server
server copied to clipboard
LandSandBoat
[SQL/LUA] Fix jug Antlion unable to use ready abilities
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
- [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.
What does this pull request do?
The abilities Sandblast and Sandpit in the BST jug Antlion pet (ChopsueyChucky) are named slightly different than the actual mob skills (which are Sand Blast and Sand Pit). This causes the jug pet to not be able to ready these abilities. To fix this we will add the space to match up the mob skill names. In game it still displays as Sandblast and Sandpit in the menu and messages.
Steps to test these changes
- !changejob 1 99
- !additem 17892 12
- Equip the jug and use Call Beast
- Use Fight on a mob
- Attempt to use Sandblast or Sandpit
- !reset if necessary
They are named differently because they are different skills that probably need a different script and a different database definition
They are named differently because they are different skills that probably need a different script and a different database definition
There are commented out records in mob_skills.sql I was originally using and creating separate mob skills that do not have spaces but this change seems to work. Happy to go down that road again if you'd like.
I wanna know what ones captures say happen for both jug and not-jug, and naming of each: space vs no space.
That dictates the path we should take. If I need to dig out my bst and buy a jug, say the word.
I wanna know what ones captures say happen for both jug and not-jug, and naming of each: space vs no space.
That dictates the path we should take. If I need to dig out my bst and buy a jug, say the word.
I definitely don't have retail access currently so any retail captures that puts me on the right path would be appreciated!
I wanna know what ones captures say happen for both jug and not-jug, and naming of each: space vs no space. That dictates the path we should take. If I need to dig out my bst and buy a jug, say the word.
I definitely don't have retail access currently so any retail captures that puts me on the right path would be appreciated!
alright, in a bit I'll go confirm which IDs are jug and which are mob, and which naming convention is correct. I'm getting unwanted OT atm coz some guy at work clicked a virus banner
This PR seems abandoned and the retail data still needs to be confirmed. I'll close it and open a new one (if needed) once I get the captures